1. Forum
  2. DOVE-Net
  3. Synchronet Programming

  • src/sbbs3/putmsg.cpp

    From Rob Swindell@VERT to Git commit to sbbs/master on Thursday, October 08, 2020 20:12:37
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/9919c23e8e52f5b7bb9a79f4
    Modified Files:
    src/sbbs3/putmsg.cpp
    Log Message:
    Don't pass-through ANSI Device Attributes (DA) requests

    putmsg(), used to display messages and display/menu files, will no longer pass-through the ANSI sequence ESC[c (found in some corrupted ANSI posts to fsxNet->FSX_BOT echo) to the client terminal since this will stimulate a (unwanted) response from the client.

    I do wonder if the outchar_esc value check should be == here instead of >=, but I'm not familiar with the string and SOS states. I wonder if any display files sent from the BBS would ever include those sequences.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Hatton@VERT/THRCORN to Rob Swindell on Friday, October 09, 2020 00:31:00
    Rob Swindell wrote to Git commit to sbbs/master <=-

    Modified Files:
    src/sbbs3/putmsg.cpp
    Log Message:
    Don't pass-through ANSI Device Attributes (DA) requests

    putmsg(), used to display messages and display/menu files, will no
    longer pass-through the ANSI sequence ESC[c (found in some corrupted
    ANSI posts to fsxNet->FSX_BOT echo) to the client terminal since this
    will stimulate a (unwanted) response from the client.

    Thank you!

    Hatton


    ... DalekDOS v(overflow): (I)Obey (V)ision impaired (E)xterminate
    --- MultiMail/Win v0.52
    þ Synchronet þ Three Corners and Beyond! http://3corners.us
  • From Digital Man@VERT to Hatton on Thursday, October 08, 2020 22:18:21
    Re: Re: src/sbbs3/putmsg.cpp
    By: Hatton to Rob Swindell on Fri Oct 09 2020 12:31 am

    Rob Swindell wrote to Git commit to sbbs/master <=-

    Modified Files:
    src/sbbs3/putmsg.cpp
    Log Message:
    Don't pass-through ANSI Device Attributes (DA) requests

    putmsg(), used to display messages and display/menu files, will no longer pass-through the ANSI sequence ESC[c (found in some corrupted ANSI posts to fsxNet->FSX_BOT echo) to the client terminal since this will stimulate a (unwanted) response from the client.

    Thank you!

    Sure. There are likely more sequences we might want to filter out of ANSI-encoded messages (or whitelist only the ones we *do* want to pass-through), but this'll work for now.

    digital man

    Synchronet "Real Fact" #95:
    Synchronet v3.15b was released in October of 2011 (5 years after v3.14a). Norco, CA WX: 62.8øF, 84.0% humidity, 3 mph ESE wind, 0.00 inches rain/24hrs

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to sbbs/master on Monday, November 02, 2020 02:30:29
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/93dc3f128816d1ddb24b6cab
    Modified Files:
    src/sbbs3/putmsg.cpp
    Log Message:
    Allow punctuation characters on either side of the markup tags

    So you can do stuff (*like this*).

    Also, we don't need to heavily scrutinize the closing tag when we come upon it because we already determined it was valid before we accepted the opening tag/character.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to sbbs/master on Sunday, November 08, 2020 13:15:19
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/9090d40fc64d791bc7dd37a3
    Modified Files:
    src/sbbs3/putmsg.cpp
    Log Message:
    Don't support back-to-back marks in markup parsing

    Addresses false-positive matches in URLs (e.g. https://minftn.net/) where the second slash was being interpreted as a the beginning of an italic markup.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to sbbs/master on Sunday, November 08, 2020 15:57:40
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/515b0854e73a3f2ff5fb89a5
    Modified Files:
    src/sbbs3/putmsg.cpp
    Log Message:
    Don't allow adjacent marked-up text.

    This allows us to ignore markup codes in a string like: "/sbbs/ctrl/*cnf*"

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Sunday, January 23, 2022 01:08:25
    https://gitlab.synchro.net/main/sbbs/-/commit/09a32c0dad9f896893f2845b
    Modified Files:
    src/sbbs3/putmsg.cpp
    Log Message:
    Basic PETSCII output column/line counting in putmsg()

    When printing a PETSCII Sequence (.seq) file, count the lines/rows and columns similar to how we would if we were using outchar() (but we don't, we use the lower-level outcom() to bypass any translations).

    This is related to issue #325:
    PETSCII seq files seem to display just fine, the problem I saw was with the auto-pausing (e.g. before a screen-clear) after displaying them.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Sunday, January 23, 2022 12:29:13
    https://gitlab.synchro.net/main/sbbs/-/commit/ca9bac807ce2a4721d6c17cb
    Modified Files:
    src/sbbs3/putmsg.cpp
    Log Message:
    Add case fall-through comment

    To address CID 345626

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Sunday, January 23, 2022 12:48:34
    https://gitlab.synchro.net/main/sbbs/-/commit/77c7a2933e156cd2f0e61619
    Modified Files:
    src/sbbs3/putmsg.cpp
    Log Message:
    Address GCC warnings: case label value exceeds maximum value for type

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Thursday, March 10, 2022 00:24:49
    https://gitlab.synchro.net/main/sbbs/-/commit/3ca2c14ff9a87674c8e8808b
    Modified Files:
    src/sbbs3/putmsg.cpp
    Log Message:
    Fix Clang warnings.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Sunday, March 12, 2023 17:36:56
    https://gitlab.synchro.net/main/sbbs/-/commit/6365250b6a0c4a3ea845918e
    Modified Files:
    src/sbbs3/putmsg.cpp
    Log Message:
    Add TRUNCATE @-code to enable line truncation when too wide for user's terminal

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (in GitKraken)@VERT to Git commit to main/sbbs/master on Sunday, March 12, 2023 18:24:18
    https://gitlab.synchro.net/main/sbbs/-/commit/2c546dc85b72fc25b1ffd6b0
    Modified Files:
    src/sbbs3/putmsg.cpp
    Log Message:
    Add TRUNCOFF @-code to turn off line truncation (if already turned on)

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (in GitKraken)@VERT to Git commit to main/sbbs/master on Monday, March 13, 2023 18:31:32
    https://gitlab.synchro.net/main/sbbs/-/commit/9a43c11f3a86ae90d9af26cd
    Modified Files:
    src/sbbs3/putmsg.cpp
    Log Message:
    Fix typo in comment

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Monday, February 03, 2025 11:11:09
    https://gitlab.synchro.net/main/sbbs/-/commit/0178043e56c04ef741cbb1cb
    Modified Files:
    src/sbbs3/putmsg.cpp
    Log Message:
    Correctly center lines of text that contain @-codes, after @center@

    @-codes weren't expanded before the text length calculation, so the centering logic (offset in the user's terminal screen) would usually be incorrect as pointed out by Nelgin in #synchronet when we were discussing the |C @-code modifier (which is to center an @-code value in a field, not the screen).

    This issue was a known limitation of the fix to issue #418 (commit 8987150bd) but now that we have the expand_atcodes() function (hooray!), this is an
    easily solvable problem.

    Note: we're now calling center() withOUT the 'msg' parameter set to true,
    which means the @center@ code goes back to the previous (to issue #418 fix) behavior of just using bputs() for the centered text (we don't need the recursive call to pustmsg() to support @-codes any longer). This was the only reason that center() grew the optional 'msg' parameter so we likely can remove that option/feature at some date.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Monday, March 24, 2025 01:14:25
    https://gitlab.synchro.net/main/sbbs/-/commit/1886c63776b7cfa454dfb9ca
    Modified Files:
    src/sbbs3/putmsg.cpp
    Log Message:
    Clean-up the hex and decimal value parsing of "extra attribute codes"

    Eliminate the unnecessary calls to snprintf() and atoi()/ahtoul() since these are simple fixed-length parses. No change in behavior, just a minor optimization.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Wednesday, January 07, 2026 03:57:55
    https://gitlab.synchro.net/main/sbbs/-/commit/0848856a624e3eeb89eaaa00
    Modified Files:
    src/sbbs3/putmsg.cpp
    Log Message:
    Add support for Wildcat! @ codes: STOP, NOSTOP, and NOCODE

    The NOCODE one is potentially useful I think (disables @-code parsing from
    that point forward in the file).

    STOP and NOSTOP are just like PCBoard's QON and QOFF

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Friday, January 09, 2026 02:24:03
    https://gitlab.synchro.net/main/sbbs/-/commit/c6212d580ce6aac69d730db4
    Modified Files:
    src/sbbs3/putmsg.cpp
    Log Message:
    PCBoard and Wildcat! color codes don't support lowercase hex digits

    From the documents and examples I could find, support for lower case hex
    digits ('a'-'f') was never "a thing" in their color codes. So let's not parse these codes as valid color codes for these platforms.

    Add support for PCBoard XON and XOFF @-codes (to enable/disable PCBoard-style color code interpretation).

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Saturday, January 10, 2026 20:48:55
    https://gitlab.synchro.net/main/sbbs/-/commit/73de34c503abde8b5312b6a6
    Modified Files:
    src/sbbs3/putmsg.cpp
    Log Message:
    CENTER @-code now abides by the P_TRUNCATE mode

    (passes current mode to Terminal::center())

    Stray WRAPOFF codes (not following a WORDWRAP code) are now ignored.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Monday, January 19, 2026 23:49:20
    https://gitlab.synchro.net/main/sbbs/-/commit/0a2695696d52a45a1b8c6895
    Modified Files:
    src/sbbs3/putmsg.cpp
    Log Message:
    Fix the Extra Attribute clearing and lines_printed counting logic

    broken since commit 374282bf814d7 (New Terminal abstraction)

    The '\n' was skipped at the bottom of the loop, so lfisnl was never set to true and we never reset the attribute (back to lightgray) at the end of a line printed, like is expected of *some* extra attribute codes.

    The lines_printed counter was never incremented, so the logic that used it (detecting false-abort) would not work.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Tuesday, January 27, 2026 18:04:07
    https://gitlab.synchro.net/main/sbbs/-/commit/ccf14ea502fa2007300b64d4
    Modified Files:
    src/sbbs3/putmsg.cpp
    Log Message:
    Add support for the WRAP @-code

    Useful with @80COLS@ to force ungraceful line wrapping (for Accession)

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Monday, February 02, 2026 02:01:42
    https://gitlab.synchro.net/main/sbbs/-/commit/88a79ac23233f4137fde59d0
    Modified Files:
    src/sbbs3/putmsg.cpp
    Log Message:
    "Inverse" markup mode fix - don't blink-inverse when high fg_attr was set

    This was likely masked by Vertrauen's use of alternate fonts that disable blinking, so I didn't notice (and I don't use the '#' markup very often).

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Sunday, February 08, 2026 08:15:07
    https://gitlab.synchro.net/main/sbbs/-/commit/232ce2d641e31ff4ca5f979d
    Modified Files:
    src/sbbs3/putmsg.cpp
    Log Message:
    Use new IS_UPPERHEXDIGIT macro

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net