https://gitlab.synchro.net/sbbs/sbbs/-/commit/7831a1c1de4379362bc931c4
Modified Files:
exec/imapservice.js
Log Message:
Fix what appears to be an extra close paren in the eval() statement here

<nelgin> Oct 12 16:05:41 bbs synchronet: srvc 0099 IMAPv4-TLS RECV: a UID SEARCH FROM "Michiel"
<nelgin> Oct 12 16:05:41 bbs synchronet: srvc 0099 IMAPv4-TLS !JavaScript /sbbs/exec/imapservice.js line 1867: SyntaxError: missing ; before statement
<nelgin> I got a different type of error

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/sbbs/sbbs/-/commit/601a9fd5c9019e796a1c4035
Modified Files:
exec/imapservice.js
Log Message:
Fix line 1172: ReferenceError: SCAN_CFG_NEW is not defined

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/1fc2657fb74666d597ca753d
Modified Files:
exec/imapservice.js
Log Message:
Fix exception when line is null

imapservice.js line 736: TypeError: line is null

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/5cb71b903d507865bffd0217
Modified Files:
exec/imapservice.js
Log Message:
Resolve line 712: Error: can't convert parseInt(line) to an integer

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/0bd86726916aa0cf4f3ffc13
Modified Files:
exec/imapservice.js
Log Message:
Don't overwrite the base global with the index base when reading config

This falls squarely into the "How did that ever work?" category.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/c967d666b2173c2d04e46a24
Modified Files:
exec/imapservice.js
Log Message:
Rename variable for consistency.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/93b91ee77ae194970b429c85
Modified Files:
exec/imapservice.js
Log Message:
Fix two isses with IMAP service...

1) user.number immediately after login() remains zero, but changes
"sometime" after. Avoid using user.number right after login()
call to generate filename. All data/user/0000.imap files can
be deleted after this change.
2) Saving Seen data would modify the object storing it when binary
seen values were used. Use JSON.parse(JSON.stringify() to make
a copy before saving and restore it afterward. Should fix issue
reported by nickshanks1 over IRC.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/7b3303e7890a73cd173ae4a8
Modified Files:
exec/imapservice.js
Log Message:
Check for invalid line thing...

Implicated in possible infinite loop/OOM problems.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/9e22b06fc5dc99f582bb3b30
Modified Files:
exec/imapservice.js
Log Message:
Improve error message

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/45f6979765f51dfd725a467c
Modified Files:
exec/imapservice.js
Log Message:
Ensure line isn't valid is it's not read in parse_string()

Thus appears to have been the root cause of the infinite loop/memory
issue. Basically, line was never replaced if it didn't match
^{[0-9]+}$ and didn't result in a number when passed to parseInt()
This resulted in an infinite loop that kept pushing zero-length
strings into an array.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/b376fc4921c58c0e3f9f5a2c
Modified Files:
exec/imapservice.js
Log Message:
Guard against Seen being undefined when saving config.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/dbed4f1a7cdd31e71f838d40
Modified Files:
exec/imapservice.js
Log Message:
Fix last commit... there are bits that aren't Seen that are saved

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/7993ca0c16241ece57a2769e
Modified Files:
exec/imapservice.js
Log Message:
Some more fixes...

Fix bseen calculation and saving
Only save seen data after all repsonses have been sent
Stop processing when the socket has been closed

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/0ed2c5120ac61523dbffd713
Modified Files:
exec/imapservice.js
Log Message:
Fix TypeError: args[1].toUpperCase is not a function

Issue #389 reported by Keyop:
srvc 0324 IMAPS <Keyop> !JavaScript /sbbs/exec/imapservice.js line 653: TypeError: args[1].toUpperCase is not a function

I'm not sure how you reproduce this error or what type args[1] is
(apparently, not a string), but this fix it regardless. Please let me
know.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/a7468eaa3752118744bc4a0e
Modified Files:
exec/imapservice.js
Log Message:
Throw more interesting errors when a continuation line read fails

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/698583017282f94fb813213e
Modified Files:
exec/imapservice.js
Log Message:
Handle invalid credentials in imapservice

Fixes #401

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/bbe3042acf2029e2798012d1
Modified Files:
exec/imapservice.js
Log Message:
Wrap the entire search logic in a try/catch statement

This should effectively turn script-terminating errors into just warnings and thus at least working-around issue #397: the exceptions will be logged as warnings intead of errors, but still logged.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/c6515aa6b972bdcb6987e102
Modified Files:
exec/imapservice.js
Log Message:
Wrap the body of parse_command() in a try/catch to turn errors into warnings

As requested by Keyop in #synchrob0yyz

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/0335c9796ce7bea2551f75c4
Modified Files:
exec/imapservice.js
Log Message:
Fix error when client supplies invalid Base64 string during auth

IIRC, the error was undefined has no properties or split() is not a function, something like that.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net