https://gitlab.synchro.net/sbbs/sbbs/-/commit/2ec90d7a5e2b30b7f2fcd471
Modified Files:
src/sbbs3/services.c
Log Message:
Place socket error description at the end of the logged messages.

Socket error descriptions on Windows can be quite long (e.g. > 128 chars) and include punctuation, so include at the end of logged socket error messages.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/9af56407b142a029bea9ec5c
Modified Files:
src/sbbs3/services.c
Log Message:
Track client counter per service again

Add the "two or three lines" that Deuce said were needed to restore this functionality.

Also got rid of some now unnecessary (void) protected_*int* return value ignoring warning-suppressors.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/452e65d884ccae63634d0cad
Modified Files:
src/sbbs3/services.c
Log Message:
Fix "clients remain" log line issue introduced in 9af56407

The service clients count is now a protected int, so deal. On Windows, this was resulting in the "total" and "served" values logged as 4294967295.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/82b99558796630a824a2427e
Modified Files:
src/sbbs3/services.c
Log Message:
Merge branch 'master' of gitlab.synchro.net:main/sbbs

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/3c911b9105131c6d84f21ce0
Modified Files:
src/sbbs3/services.c
Log Message:
Fix UDP buffer memory leak when max clients reached

Caught by Coverity-scan CID 330055

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/a1f9abb72c2b6e2fb129fedd
Modified Files:
src/sbbs3/services.c
Log Message:
Set fds to NULL before recycle.

Likely the cause of the crash that killed cvs.synchro.net last night

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/112526fe8dc12c84243955c2
Modified Files:
src/sbbs3/services.c
Log Message:
Include user alias in logged JS error/warning messages

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/7117b4d8a85474975ea81c78
Modified Files:
src/sbbs3/services.c
Log Message:
Probably doesn't resolve the Coverity issue

But good practice anyway

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/b293b6e53e751fff783f90c2
Modified Files:
src/sbbs3/services.c
Log Message:
Allow a per-service "LowestLogLevel" setting

Have a service (e.g. imapservice.js) that logs errors that you'd rather not fill your error.log file with? Set that service's "LowestLogLevel" to "Warning" in your services.ini file ("lower" means "more severe" when it comes to log levels, so this would set the maximum severity to Warning).

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/9bd552ed13142092f54e2b2b
Modified Files:
src/sbbs3/services.c
Log Message:
Improve JavaScript-related error messages and fix potential JS runtime leak

If a new JS context could not be created for any reason, a JS runtime would still be allocated (and leaked), potentially leading to out of memory situations which had been seen (before this change) on vert.synchro.net.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/4d8bb33e8ffd2e37e5e7b4ba
Modified Files:
src/sbbs3/services.c
Log Message:
Use XSAFECOPY in place of SAFECOPY to avoid NULL pointer checks

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/f40e7fbd4471344721a998e9
Modified Files:
src/sbbs3/services.c
Log Message:
Fix a couple of potential NULL-pointer deferences in js_initcx() failure cases

service_client->client is NULL in these failure/error cases, so get the protocol string from the service_client->service (which is not NULL) instead.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/d057ff6d2d14f5be4e219833
Modified Files:
src/sbbs3/services.c
Log Message:
Fix valgrind-reported memleak (on recycle), not freeing interfaces string list

(seeing a pattern here) :-)

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/41b6e894c55e20e20a4aae64
Modified Files:
src/sbbs3/services.c
Log Message:
Log client IP address in "Logging in" log message

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/76706b71762af88781ab5922
Modified Files:
src/sbbs3/services.c
Log Message:
Fix bug in previous commit: wrong client->addr

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/5634092ad3f89d6e63fd52d9
Modified Files:
src/sbbs3/services.c
Log Message:
Fix apparent session leak in services.

It appears that after successful completion of a JS service, the
TLS session is never destroyed.

If this fix isn't valid for #707, we should see a bunch of
"Destroying a session (...) that's not in sess_list" log messages

Thanks Keyop!

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/9c9d6a151e2f7fa2e19305e9
Modified Files:
src/sbbs3/services.c
Log Message:
Another time_t printf

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net