1. Forum
  2. FidoNet
  3. SYNCHRONET

  • KNK.JS - Possible Scores Bugs

    From WitNik@1:103/705 to All on Monday, November 30, 2020 20:09:16
    All,

    Here's a copy of the scores file being generated on my board:

    * Kannons and Katapults Scoreboard for the Month of November *

    Rank Name Games Wins Losses Win % Score --------------------------------------------------------------------
    0 The Mandalorian 1 1 0 100 % 20,925
    1 WitNik 1 0 1 0 % 0 --------------------------------------------------------------------

    * Kannons and Katapults Total Score for the Month of January *

    Rank Name Games Wins Losses Win % Score --------------------------------------------------------------------
    1 All Users 1 0 1 0 % 20,925
    2 King Computer 1 1 0 100 % 19,183 --------------------------------------------------------------------

    There were 2 games played in November. One by WitNik (who lost) and one by The Mandalorian who won. The top portion looks ok, but the ranking doesn't begin with 1 it begins with 0 (minor issue).

    I believe the bottom portion is supposed to show the totals for the same month.

    In this case, there should be 2 games for all users with 1 win and 1 loss, along with a 50% 'Win %' and the same for King Computer. The total number of games and win/loss columns are off, but the scores columns are correct.

    Also, title of the second section refers to "Month of January" vs. the current month. When referencing the code, line 1501 is not using the "+nowmonth+" variable from section 1, so the title is probably an easy fix.

    In further referencing the code, it looks like the variables computer_wins and computer_losses are reused in most of the second section and appear to lead to the source of the miscalculations. I haven't gone futher as I wanted to know if it is more preferable to attempt to produce a fix for something like this or if it better to offer a detailed report?

    Thanks,
    -WitNik

    ---
    þ Synchronet þ * Origin: Beggar's Canyon - beggarscyn.com *
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From mlong@1:103/705 to WitNik on Thursday, December 03, 2020 01:01:08
    I'm pretty sure nobody is maintaining that door...I did a fix for bbs name and digitalman did a fix for a misspelled month. If you have the ability to look at the code and figure out a fix, you could submit a merge request to digitalman

    ---
    þ Synchronet þ Inner Realm BBS - Charlotte, NC - innerrealmbbs.us
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From WitNik@1:103/705 to mlong on Thursday, December 03, 2020 08:22:28
    Re: KNK.JS - Possible Scores Bugs
    By: mlong to WitNik on Thu Dec 03 2020 01:01 am

    I'm pretty sure nobody is maintaining that door...I did a fix for bbs name and digitalman did a fix for a misspelled month. If you have the ability to look at the code and figure out a fix, you could submit a merge request to digitalman


    Thanks! I'll give it a shot.

    -WitNik

    ---
    þ Synchronet þ * Origin: Beggar's Canyon - beggarscyn.com *
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)