https://gitlab.synchro.net/sbbs/sbbs/-/commit/81492c8a4be0f5a00a2994dd
Modified Files:
src/syncterm/term.c
Log Message:
Add original XMODEM send/receive protocol options.

Previously, SyncTERM only supported the more modern XMODEM-1K uploads and XMODEM-CRC downloads. This commit adds support for XMODEM-128 uploads and XMODEM-Checksum downloads.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/sbbs/sbbs/-/commit/fea6104bc351255a90e45937
Modified Files:
src/syncterm/term.c
Log Message:
Fix array size issues introduced on last commit.

Options were added to arrays without increasing the size of arrays.
This caused the menu generated from them to depend on uninitialized
memory and potentially crash or emit garbage.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/ebd7708defaa3c5fa35dd281
Modified Files:
src/syncterm/term.c
Log Message:
Include timestamps in file transfer log lines

(emulating the syslog date/timestamp format). Makes debugging file transfer issues easier.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/ecc690f573875558e0cf0a21
Modified Files:
src/syncterm/term.c
Log Message:
Handle the new value of CIO_KEY_QUIT better.

The low byte is no longer zero.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/0f312cb33a391e7addf592f4
Modified Files:
src/syncterm/term.c
Log Message:
Remove some backslashes from the ends of lines...

Presumably these were part of macros once and never cleaned up?

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/2ca3bc02fda2de5eb85d8e15
Modified Files:
src/syncterm/term.c
Log Message:
In XModem/YModem, when total_files reaches zero, stop downloading.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/24739b234af6f95de7651d7b
Modified Files:
src/syncterm/term.c
Log Message:
Revert last change... YModem is supposed to send a termination block.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/581087f329a38dc7130b0c76
Modified Files:
src/syncterm/term.c
Log Message:
Work around broken sz

Some broken protocol drivers (like sz) don't send a YModem terminate
at the end of a batch (or maybe just after a single file?) so SyncTERM
ends up trying to fall back from G to CRC-16 to 8-bit before ending.

This detects when the last known file was received, and if the YModem
header that follows is not correct, aborts the transfer.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/d8920e0602d46033d5949aa0
Modified Files:
src/syncterm/term.c
Log Message:
Better comment conformance in key parsing

There's a comment saying we set key=0 when we consume it... do so
in a couple cases where it wasn't done.

Range check the key before sending to the remote.

This should not actually do anything different, but in the future
if things are changed at least the comments won't be misleading.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/b815404814b9dd6819c14c13
Modified Files:
src/syncterm/term.c
Log Message:
Fix ETA calculation.

Use remaining bytes divided by CPS rather than total estimated time
minus elapsed time.

We squirrley on resumed ZModem downloads.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/cd3a3a2d9f5b63b722194c80
Modified Files:
src/syncterm/term.c
Log Message:
Fix b64 decode buf length calculation

Previously, b64_decode was being asked to decode past the end of
the application string.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/29eb84a9762d210550e54c0e
Modified Files:
src/syncterm/term.c
Log Message:
Since we have the code to generate the correct gamma transfer, let's
not scale it in one colour space before translating it to a different
one.

Also, since almost all PPMs will use a maxval of 255, compile that
in as the default so we don't need to generate it.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/6cfed436084fb6acf5591e7e
Modified Files:
src/syncterm/term.c
Log Message:
Initialize pointer to NULL to avoid free()ing unallocated memory.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/fafed094c52b0ca167e6fd51
Modified Files:
src/syncterm/term.c
Log Message:
Initialize mbuf too.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/7aa6f21e42f94ff7807279a5
Modified Files:
src/syncterm/term.c
Log Message:
Resolve GCC 12.2 warnings

warning: format `%s' expects argument of type `char *', but argument 4 has type `void *'
warning: `sprintf' writing a terminating nul past the end of the destination

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/d0650fbaeb167af68d51d2bf
Modified Files:
src/syncterm/term.c
Log Message:
Perform unicode-to-codepage for US-ASCII input

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/79831364263801c9e3a6141d
Modified Files:
src/syncterm/term.c
Log Message:
include <math.h> for pow()

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/12eb94e24a34dee6eea938db
Modified Files:
src/syncterm/term.c
Log Message:
warning: pointer targets in passing argument 1 of `strcmp' differ in signedness

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/a47f94b80878b4d6597234a6
Modified Files:
src/syncterm/term.c
Log Message:
Fix GCC v12.2.0 -O1 warnings

warning: `maxval' may be used uninitialized
warning: `inch' may be used uninitialized

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/450bc21718802b2e4f33e74a
Modified Files:
src/syncterm/term.c
Log Message:
Actually fall-through like the comment says.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/a910575e7f831c59501d5332
Modified Files:
src/syncterm/term.c
Log Message:
When backspace sends delete, send CSI 3 ~ for delete.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/e59a247c7387ec63a8a6a069
Modified Files:
src/syncterm/term.c
Log Message:
We need to call uifcbail() after calling show_bbslist()

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/bbb6ab35ba69856c3ebeb77a
Modified Files:
src/syncterm/term.c
Log Message:
Remove unused variable.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/2f6eaf2213e3d7865618bf23
Modified Files:
src/syncterm/term.c
Log Message:
Attempt to silence silly Coverity warning.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

Re: src/syncterm/term.c
By: Deuc¨ to Git commit to main/sbbs/master on Sun Mar 31 2024 12:13 pm

Attempt to silence silly Coverity warning.

Good luck.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/93a8c94862d8c76146460413
Modified Files:
src/syncterm/term.c
Log Message:
Fix bug generating SAUCE date introduced by commit dcf8c35f9b

Using snprintf() prevents the last character of the date from
being put into the string.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/829c5009fcfb0b2c5be5eac2
Modified Files:
src/syncterm/term.c
Log Message:
Fix last commit.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/02460447d3eaa1f1532229e4
Modified Files:
src/syncterm/term.c
Log Message:
Fix SAUCE date properly... avoid writing past the end of the buffer

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/f25fafae6c6cc27761998909
Modified Files:
src/syncterm/term.c
Log Message:
Fix some remains of input weirdness...

Now that the conio layer is handling translation of character sets,
the key handler in term.c should only handle terminal related
translations (such as backspace to delete).

This fixes bug 159, but there's still some inconsistency across
the various backends on how they handle C0 control characters and
input characters outside of US-ASCII.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/b50d96f6f771017444853a31
Modified Files:
src/syncterm/term.c
Log Message:
Make Return send #, use CTRL-Return for return

Not tested on Windows.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/774d285494551046a4e73ec8
Modified Files:
src/syncterm/term.c
Log Message:
Map underscore to pound

I think this map may be the final one.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/2132c3f3d4af3b3fe85029fa
Modified Files:
src/syncterm/term.c
Log Message:
Fix MD5 calculation for cache files over 32k

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/77376487d3dac208e29012f2
Modified Files:
src/syncterm/term.c
Log Message:
At least make the comments correctish.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/f6a44d1477cfede0e65d6489
Modified Files:
src/syncterm/term.c
Log Message:
Properly handle the case where libjxl thread support is missing

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/e3241a522e3af5f5171e4917
Modified Files:
src/syncterm/term.c
Log Message:
Fix typo in lazy "fix"

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/c56c9d9032c033ccc81651bd
Modified Files:
src/syncterm/term.c
Log Message:
Convert ^G back to 7 when sent.

This technically fixes issue 137 which specifically asked for
"backslash", but backspace (^H) and tab (^I) along with CR (^M)
still do a different thing than they do on Atari keyboards.

Further, CTRL-Q and CTRL-S are used by SyncTERM for Quit and Menu
respectively, so someone expecting all the Atari "stuff" to work
will still be disappointed.

This is a general problem with non-PC emulation (ie: Prestel, Atari,
and Commodore) that really needs some kind of general solution.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/b9333a0b4f9be867f964b278
Modified Files:
src/syncterm/term.c
Log Message:
Another attempt to silence Coverity.

This may be the first time in my life that I've used difftime()...
which is strictly one of only two things you're actually allowed
to do with a time_t per the C standard (the other is convert into
a broken-down time).

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/ba945f3c202ec0c320944c52
Modified Files:
src/syncterm/term.c
Log Message:
Try to tell Coverity that getch() isn't constant.

I'm not sure if I can do this with events, or just issues, and I
don't want to directly annotate this issue because that could lead
to missing an issue after a future code change.

The return value of getch() will never be const though.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/cdca88a29a653607fa5babd6
Modified Files:
src/syncterm/term.c
Log Message:
Actually, mark this as suppress since I would like this one to go away

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/1fe1adc1757d2e778d57044d
Modified Files:
src/syncterm/term.c
Log Message:
Don't fiddle with the status bar fonts if we're not going to update it.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/430629d878abb64bc7f852b7
Modified Files:
src/syncterm/term.c
Log Message:
Let time get big enough to be too big

Previous commit capped it too early.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/3c9e6b01e1a15486dfacdb32
Modified Files:
src/syncterm/term.c
Log Message:
Don't sleep() after receiving input.

2.1 seconds.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/9ab17ee464c2f66b5570863a
Modified Files:
src/syncterm/term.c
Log Message:
Don't egregiously use strlen() for ZRQ and OOII buffers.

We're building these one byte at a time, we know the length.
1.98s

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/855af348ce4a9b189aa553aa
Modified Files:
src/syncterm/term.c
Log Message:
Fix legacy attributes when redrawing status bar

legacy_attr is the CGA attribute, not ANSI colours. :D
Fixes ticket 183.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/985cc21745ba1a7c166c31d8
Modified Files:
src/syncterm/term.c
Log Message:
Send login info in a single conn_send() call

Should "fix" the timing difference in login info between modes.
This removes a 10ms SLEEP() between the different pieces of data,
and would likely have resolved ticket 185 if it wasn't already
closed.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/5024cc95cb2bb8845dfe4105
Modified Files:
src/syncterm/term.c
Log Message:
Fix up the Mode 7/Prestel key bindings to match Commstar

This mostly just changes the arrow key bindings and adds support
for Ctrl+Fx and Shift+Fx, and makes End Copy.

The big change though is that Page Down, not Tab now toggles reveal
mode. Sorry all you guys with 60% keyboards.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/9ffa3a6e6b9d366918fc1aeb
Modified Files:
src/syncterm/term.c
Log Message:
Make F3 toggle reveal just like PgDown

That's what Commstar uses in Prestel mode after all.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/5d91359891c85012a9f6c1c6
Modified Files:
src/syncterm/term.c
Log Message:
Set up CP437 mode before zmodem auto up/download

Fixes use of system font during up/downloads when auto-started.

Ticket 194

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/d6e4f682df39c17355dea370
Modified Files:
src/syncterm/term.c
Log Message:
Pass all control keys through to remote in Beeb mode

Implements feature request #104

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/d2e8d94e32ce0e32856d7bb9
Modified Files:
src/syncterm/term.c
Log Message:
In PETSCII mdoes, map BS to DEL

C64 doesn't have a backspace key, so treat backspace the same as
DEL.

Closes tick 197.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net