1. Forum
  2. DOVE-Net
  3. Synchronet Programming

  • src/xpdev/gen_defs.h

    From Deuce@VERT to Git commit to sbbs/master on Saturday, November 21, 2020 02:12:43
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/6a3fd5591683615872c22eb4
    Modified Files:
    src/xpdev/gen_defs.h
    Log Message:
    define U?INT[0-9]+_(MIN|MAX) for builds without stdint.h (ie: Borland)

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuce@VERT to Git commit to sbbs/master on Saturday, November 21, 2020 02:13:29
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/ce5cf032d42db61e4aff72ef
    Modified Files:
    src/xpdev/gen_defs.h
    Log Message:
    Fix UINT32_MAX definition in previous commit

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Saturday, May 22, 2021 15:52:38
    https://gitlab.synchro.net/main/sbbs/-/commit/c5bdb26443df75e6d03eebdb
    Modified Files:
    src/xpdev/gen_defs.h
    Log Message:
    Character 255 is a non-breaking space in CP437

    Now IS_WHITESPACE() will return true for that char and this allows things like truncsp() to truncate trailing white-space (e.g. from a FILE_ID.DIZ), even if it contains a terminating 0xFF character for some unknown reason.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Monday, November 22, 2021 20:53:40
    https://gitlab.synchro.net/main/sbbs/-/commit/b1fcb452d08cbf462dcf750b
    Modified Files:
    src/xpdev/gen_defs.h
    Log Message:
    MSVC 1.5c defines _MSDOS, not __MSDOS__

    This change needed to build dosxtrn.exe (again).

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¿@VERT to Git commit to main/sbbs/master on Friday, February 25, 2022 13:05:26
    https://gitlab.synchro.net/main/sbbs/-/commit/85d3f30f52723d9d0cad818f
    Modified Files:
    src/xpdev/gen_defs.h
    Log Message:
    Even when MSVC has inttypes.h, it still doesn't have ssize_t

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Tuesday, January 24, 2023 12:44:00
    https://gitlab.synchro.net/main/sbbs/-/commit/c0e857c930feb9833d40617f
    Modified Files:
    src/xpdev/gen_defs.h
    Log Message:
    Make SAFECOPY() even safer by not passing NULL destination to strncpy()

    This should resolve (new) CID 434884 and 434885.

    Also, remove the SAFECOPY_USES_SPRINTF check/block - nobody enables this.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on ChromeOS)@VERT to Git commit to main/sbbs/master on Thursday, January 26, 2023 23:30:10
    https://gitlab.synchro.net/main/sbbs/-/commit/1e3a6b84e7bc1485b2a96828
    Modified Files:
    src/xpdev/gen_defs.h
    Log Message:
    Revert "Make SAFECOPY() even safer by not passing NULL destination to strncpy()"

    This reverts commit c0e857c930feb9833d40617f00ff5d11be9f7772.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on ChromeOS)@VERT to Git commit to main/sbbs/master on Thursday, January 26, 2023 23:45:00
    https://gitlab.synchro.net/main/sbbs/-/commit/ea99ca801e63268479f91e94
    Modified Files:
    src/xpdev/gen_defs.h
    Log Message:
    Add XSAFECOPY (extra safe copy) that won't pass NULL to strncpy()

    The previous (reverted) change to SAFECOPY would double-resolve the (src) argument and caused weird side effects.

    Again, removes SAFECOPY_USES_SNPRINTF since it was unused.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¿@VERT to Git commit to main/sbbs/master on Friday, March 22, 2024 11:38:39
    https://gitlab.synchro.net/main/sbbs/-/commit/ffd5385d1510e7da8a547970
    Modified Files:
    src/xpdev/gen_defs.h
    Log Message:
    Use strlcpy() for X?SAFECOPY() macros.

    Also, for DEBUG builds, add a static assertion that
    sizeof(dst) != sizeof(void*) to catch the most common breakage.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¿@VERT to Git commit to main/sbbs/master on Friday, March 22, 2024 11:42:26
    https://gitlab.synchro.net/main/sbbs/-/commit/d13fa3bd3eb4953a587c6d5d
    Modified Files:
    src/xpdev/gen_defs.h
    Log Message:
    Use static_assert() macro instead of _Static_assert keyword

    More compatible with C++ that way.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Friday, March 22, 2024 11:48:03
    https://gitlab.synchro.net/main/sbbs/-/commit/a8c0ac5da5374f83333b570e
    Modified Files:
    src/xpdev/gen_defs.h
    Log Message:
    Fix stale comment about XSAFECOPY (now uses strlcpy, not strncpy)

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¿@VERT to Git commit to main/sbbs/master on Friday, March 22, 2024 11:48:38
    https://gitlab.synchro.net/main/sbbs/-/commit/2b3a174068b33c4c947b2b21
    Modified Files:
    src/xpdev/gen_defs.h
    Log Message:
    static_assert() only available with C11 and higher.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¿@VERT to Git commit to main/sbbs/master on Friday, March 22, 2024 11:50:56
    https://gitlab.synchro.net/main/sbbs/-/commit/406ea9488765141c69185e81
    Modified Files:
    src/xpdev/gen_defs.h
    Log Message:
    Borland expects ()

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¿@VERT to Git commit to main/sbbs/master on Friday, March 22, 2024 11:53:02
    https://gitlab.synchro.net/main/sbbs/-/commit/a987cf4b49ff92f4925f7106
    Modified Files:
    src/xpdev/gen_defs.h
    Log Message:
    Stop interlacing preprocessor stuff.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¿@VERT to Git commit to main/sbbs/master on Friday, March 22, 2024 23:11:54
    https://gitlab.synchro.net/main/sbbs/-/commit/c64357b949c68ff54489f1e1
    Modified Files:
    src/xpdev/gen_defs.h
    Log Message:
    include genwrap.h at the end of gen_defs.h for strlcpy()/strlcat().

    This whole library is starting to get crufty and could use a room
    at a hackathon.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Sunday, March 24, 2024 17:58:57
    https://gitlab.synchro.net/main/sbbs/-/commit/be523ad92bf537adb4c195f3
    Modified Files:
    src/xpdev/gen_defs.h
    Log Message:
    Remove obsolete note comment about genwrap.h

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¿@VERT to Git commit to main/sbbs/master on Tuesday, September 30, 2025 10:03:32
    https://gitlab.synchro.net/main/sbbs/-/commit/59a695825a13d6898fb804a0
    Modified Files:
    src/xpdev/gen_defs.h
    Log Message:
    Don't rely on locale for isspace()

    With truncsp() and SKIP_WHITESPACE() dominating runtime for INI
    parsing now, the locale lookups needed for every isspace() call
    have become significant. Since we likely don't actually want isspace()
    to use the local, expand the C locale whitespace table directly.

    This provides a 20% performance boost to INI parsing when using
    the FastParse calls (much smaller using other parsing functions)
    and is likely to improve various other whitespace-heavy things.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¿@VERT to Git commit to main/sbbs/master on Thursday, October 09, 2025 16:02:28
    https://gitlab.synchro.net/main/sbbs/-/commit/a4a69d20760f5f5608658fe5
    Modified Files:
    src/xpdev/gen_defs.h
    Log Message:
    inttypes.h and stdint.h are part of C99 and C++17

    So we can assume the exist if we're using a C99 or newer compiler.
    stdint.h is in C++11 (though inttypes.h isn't)

    This has been the most painful bit of xpdev for a while now.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¿@VERT to Git commit to main/sbbs/master on Friday, October 10, 2025 12:45:56
    https://gitlab.synchro.net/main/sbbs/-/commit/a136e0d08cd0da404a519b01
    Modified Files:
    src/xpdev/gen_defs.h
    Log Message:
    Both inttypes.h and stdint.h were in C++11

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Tuesday, January 13, 2026 22:16:37
    https://gitlab.synchro.net/main/sbbs/-/commit/3d7d3472419f9be65f6d7e29
    Modified Files:
    src/xpdev/gen_defs.h
    Log Message:
    Suppress a Coverity issue with typecast

    CID 640989: (CONSTANT_EXPRESSION_RESULT)

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Wednesday, January 14, 2026 15:28:13
    https://gitlab.synchro.net/main/sbbs/-/commit/cec1342f9738b7d2eae4ce02
    Modified Files:
    src/xpdev/gen_defs.h
    Log Message:
    Forgot the extra parens needed in macros

    Resolve a bunch of Coverity issues, e.g.
    CID 641215: (CONSTANT_EXPRESSION_RESULT)
    CID 641216: Integer handling issues (CONSTANT_EXPRESSION_RESULT)
    CID 641217: (CONSTANT_EXPRESSION_RESULT)
    CID 641218: (CONSTANT_EXPRESSION_RESULT)
    CID 641219: Integer handling issues

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Sunday, February 08, 2026 08:15:07
    https://gitlab.synchro.net/main/sbbs/-/commit/0269fafedfe1cb44a77fd6e6
    Modified Files:
    src/xpdev/gen_defs.h
    Log Message:
    Create IS_UPPERHEXDIGIT macro

    Like IS_HEXDIGIT, but only for uppercase hex

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Thursday, February 19, 2026 15:32:39
    https://gitlab.synchro.net/main/sbbs/-/commit/41a56832d5f1c08beb68c43f
    Modified Files:
    src/xpdev/gen_defs.h
    Log Message:
    Remove the typecast before CP437_NO_BREAK_SPACE check causing Clang warnings

    ... was added in commit 3d7d34724 to resolve Coverity issue. So that Coverity issue will return. <shrug>

    Add more parens for macro-safety.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on macOS)@VERT to Git commit to main/sbbs/master on Wednesday, March 18, 2026 22:41:49
    https://gitlab.synchro.net/main/sbbs/-/commit/8fd7e6a66dc4ccc549d76fb8
    Modified Files:
    src/xpdev/gen_defs.h
    Log Message:
    Typecast both sides of the equality comparison in IS_WHITESPACE definition

    to make Clang happy

    warning: result of comparison of constant 'CP437_NO_BREAK_SPACE' (-1) with expression of type 'const unsigned char' is always false

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net