1. Forum
  2. DOVE-Net
  3. Synchronet Programming

  • src/sbbs3/netmail.cpp

    From Rob Swindell@VERT to Git commit to main/sbbs/master on Wednesday, December 09, 2020 23:37:08
    https://gitlab.synchro.net/main/sbbs/-/commit/bc6cddb0a725985e819e1fe5
    Modified Files:
    src/sbbs3/netmail.cpp
    Log Message:
    Address GCC warning

    `%s' directive writing up to 255 bytes into a region of size between 103 and 128
    reported by Nelgin.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Sunday, February 14, 2021 23:17:15
    https://gitlab.synchro.net/main/sbbs/-/commit/9683b9d22c3c7e2cce1b29b2
    Modified Files:
    src/sbbs3/netmail.cpp
    Log Message:
    Handle filelength() failure gracefully

    Addresses Coverity's NEGATIVE_RETURNS bug-checker issue.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Monday, February 15, 2021 01:12:32
    https://gitlab.synchro.net/main/sbbs/-/commit/c037303847e32cd0db195573
    Modified Files:
    src/sbbs3/netmail.cpp
    Log Message:
    Address gcc warning: comparison of integer expressions of different signedness

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Monday, February 15, 2021 19:31:37
    https://gitlab.synchro.net/main/sbbs/-/commit/d19237210fb6279fba625ce8
    Modified Files:
    src/sbbs3/netmail.cpp
    Log Message:
    Address gcc warning: comparison of integer expressions of different signedness

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Tuesday, February 22, 2022 13:10:22
    https://gitlab.synchro.net/main/sbbs/-/commit/c7b1bed6b4c882121966d43a
    Modified Files:
    src/sbbs3/netmail.cpp
    Log Message:
    Fix network user/address look-up (using qnet/users.dat)

    The QWKnet user look-up feature was broken as of commit e4fc5d04d9c6570e31e (a year ago).

    Just noticed this regression as Andre asked in IRC about looking up network users for netmail. This feature worked for QWKnet users/addresses, at least, and now will work again.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Wednesday, March 02, 2022 13:25:51
    https://gitlab.synchro.net/main/sbbs/-/commit/bea7394e614931fc63961086
    Modified Files:
    src/sbbs3/netmail.cpp
    Log Message:
    Detect smb_[f]allocdat() failures in qnetmail()

    CID 319140

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Wednesday, March 02, 2022 13:25:51
    https://gitlab.synchro.net/main/sbbs/-/commit/cb9a3753fee63c37e50677f3
    Modified Files:
    src/sbbs3/netmail.cpp
    Log Message:
    Fix issue in previous commit: no need to free what wasn't allocated

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Sunday, March 13, 2022 00:28:10
    https://gitlab.synchro.net/main/sbbs/-/commit/7e1c3c3d3944249c05686250
    Modified Files:
    src/sbbs3/netmail.cpp
    Log Message:
    Fix CID 319119: Unchecked return value from library

    Actually probably doesn't fix it, but what'evs

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Friday, June 10, 2022 22:54:03
    https://gitlab.synchro.net/main/sbbs/-/commit/121ce679be01b8f4fa5131c2
    Modified Files:
    src/sbbs3/netmail.cpp
    Log Message:
    Safe string formatting of fido netmail time header field

    Suppresses GCC warning. I suppose some of these fields could be more digits than expected.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Friday, December 29, 2023 17:10:28
    https://gitlab.synchro.net/main/sbbs/-/commit/8f54b5ce31565dd8031982b0
    Modified Files:
    src/sbbs3/netmail.cpp
    Log Message:
    Fix error path memory leak (unlikely, but not impossible)

    CID 462234

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Thursday, January 22, 2026 15:08:08
    https://gitlab.synchro.net/main/sbbs/-/commit/4aa2274c97e8e79e46d3d757
    Modified Files:
    src/sbbs3/netmail.cpp
    Log Message:
    Refuse to send netmail to our own addresses

    as Keyop pointed out, at least for FTN netmail, this would just create an orphaned .msg file in the netmail directory: SBBSecho won't import it (by default) because it was created locally and won't export it to a packet because you don't have a link to yourself. Internet email would just loop back
    (if everything's configured and working) and sending to your own QWK-ID would've already been rejected. Hopefully nobody is depending on the Internet e-mail loopback functionality.

    There were sysop exemptions for when the "Allow Sending of ..." settings in SCFG->Networks->Internet E-mail and FidoNet were set to "No", but now those
    are defeated (if they're set to, even the sysop won't be able to send e-mail/ NetMail). If we really want to control *who* can send netmail, we should
    be using ARS for that rather than a toggle that just (confusingly) doesn't apply to the sysop(s).

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Wednesday, February 11, 2026 22:20:06
    https://gitlab.synchro.net/main/sbbs/-/commit/f0545836096d44c51b14bdb1
    Modified Files:
    src/sbbs3/netmail.cpp
    Log Message:
    Redirect netmail sent to local user's netmail address to personal inbox

    If a user attempts to send netmail to a netmail address that is invalid (because it's local) yet there's a user with that address configured as their netmail address (in the userbase), send the message as an email to that user. Rather than just failing with error "Invalid NetMail address: <name@address>"

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Thursday, February 19, 2026 22:53:59
    https://gitlab.synchro.net/main/sbbs/-/commit/002aa81ea984222fb9e48845
    Modified Files:
    src/sbbs3/netmail.cpp
    Log Message:
    Fix bug: wrong smb_t* passed in here

    Would cause a NULL fp to try to be used to quote the message text

    Introduced in commit f0545836096d44

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net